Terminals

Commented Issue: UAC warning on win8 [34015]

emoxam — Fri, 24 May 2013 18:16:13 GMT

3.0.145
UAC warning displays on Terminals start
Comments: ** Comment from web user: emoxam **

I installed version 2 and after that i copy new releases into Terminals folder, so i guess i can say u use portable configuration.
There is no UAC at https://terminals.codeplex.com/wikipage?title=Upgrade%20to%20version%203.0&referringTitle=Documentation

Source code checked in, #102902

jirkapok — Fri, 24 May 2013 16:33:00 GMT

Added temporar check for entity validation errors.

Commented Issue: UAC warning on win8 [34015]

jirkapok — Fri, 24 May 2013 14:45:01 GMT

3.0.145
UAC warning displays on Terminals start
Comments: ** Comment from web user: jirkapok **

Do you use portable configuration or local profile? See documentation in: https://terminals.codeplex.com/wikipage?title=Upgrade%20to%20version%203.0&referringTitle=Documentation

Commented Unassigned: Passwords in favorites are lost! [34075]

jirkapok — Fri, 24 May 2013 14:41:55 GMT

The program complains that there is a problem with every password in the favorites configuration.

Tracing the code I see there is an exception being caught.

My favorites.xml file is from version 3.0 beta 1 and I'm loading it with a corrected 3.0 beta 2 for the correct loading of notes.
Comments: ** Comment from web user: jirkapok **

I am not able to reproduce. Upgrade from CTP1 wouldn't be supported. Does the issue appear, when upgrading from v2.0 to the last CPT 2?

Commented Issue: installing terminals freezes the computer [34067]

jirkapok — Fri, 24 May 2013 14:28:25 GMT

When installing Terminals on Windows 7 64 bit , with the option enabled to discover previous rdp connections, the installer freezes the computer, crashing it.
Comments: ** Comment from web user: jirkapok **

Unable to reproduce. Is the user and admin? Can you provide log file and screen shot, which all options did you selected in the wizard?

Commented Issue: Import Active Directory doesn't return more than 1000 results [33692]

jirkapok — Fri, 24 May 2013 14:14:33 GMT

Please add the following line to ActiveDirectoryClient.cs starting from line 92 to resolve the issue. It would even be nicer if Sizelimit is configurable via settings.

mySearcher.PageSize = 1000;
mySearcher.SizeLimit = 5000;

See documentation:
https://terminals.codeplex.com/wikipage?title=Organize%20favorites
Comments: Associated with changeset 102900.

Source code checked in, #102900

jirkapok — Fri, 24 May 2013 14:14:31 GMT

Fixed maximum number of computers found in Active directory search tool.

Edited Issue: installing terminals freezes the computer [34067]

jirkapok — Thu, 23 May 2013 22:45:27 GMT

When installing Terminals on Windows 7 64 bit , with the option enabled to discover previous rdp connections, the installer freezes the computer, crashing it.

Closed Unassigned: Loading of favorites.xml when notes not in base64 fails [34074]

jirkapok — Thu, 23 May 2013 22:42:16 GMT

I have a favorites.xml from the first beta.
The second beta fails to load the file without any error show to the user, however the file is not loaded and upon tracing the code I see that now the Notes field is loaded/save in Base64.
An exception is raised when trying to convert the notes (in plain text in my favorites.xml file) from Base64.

So, the exception should be handled on loading the xml and revert to using the unencoded notes text.
Comments: Already fixed with another issue with identical topic.

Closed Issue: Notes field lost with current source [34077]

jirkapok — Thu, 23 May 2013 22:40:34 GMT

Turns out changing the notes field persistence to Base64 without FIRST converting it will lose your current notes. At minimum, we should do this in Source\Terminals\Data\Favorites\Favorite.cs

```
private static String DecodeFrom64(String encodedData)
{
if (encodedData == null)
return null;

try
{
Byte[] encodedDataAsBytes = Convert.FromBase64String(encodedData);
String returnValue = Encoding.Unicode.GetString(encodedDataAsBytes);
return returnValue;
}
catch (FormatException)
{
// it's not Base64 YET... because we're reading from before we
// encoded things.
return encodedData;
}
}

```
Comments: Applied patch by IDisposable. This helps notes from CTP1 to survive.

Commented Issue: Notes field lost with current source [34077]

jirkapok — Thu, 23 May 2013 22:39:38 GMT

Source code checked in, #102890

jirkapok — Thu, 23 May 2013 22:39:36 GMT

Fixed resolution of notes, whe previous notes were not encoded. This helps to survive notest from CTP1

Edited Issue: Notes field lost with current source [34077]

jirkapok — Thu, 23 May 2013 22:30:42 GMT

Closed Issue: Version.cs implements part of equality contract [34078]

jirkapok — Thu, 23 May 2013 22:27:53 GMT

If you override operator ==, you should also ALWAYS override Equals(object obj) and GetHashCode(). Add this code to Source\SqlScriptRunner\Versioning\Version.cs

```
public override bool Equals(object obj)
{
if (Object.ReferenceEquals(this, obj))
return true;

var that = obj as Version;

if (Object.ReferenceEquals(that, null))
return false;

return that == this;
}

public override int GetHashCode()
{
return (Major * 37 + Minor) * 37 + Build;
}

```
Comments: Resolved with changeset 102889.

Source code checked in, #102889

jirkapok — Thu, 23 May 2013 22:27:50 GMT

Applied patch by IDisposable. Added missing Equals and GetHascode methods to Version class of SqlScriptRunner.

Edited Issue: Version.cs implements part of equality contract [34078]

jirkapok — Thu, 23 May 2013 22:26:50 GMT

Script runner is unfinished feature, which is not present in current release. At least i know the Equality constraints in .NET, so simply i will apply your patch and close this issue.

Commented Unassigned: Database baseline configuration not great. [34063]

adamseniuk — Thu, 23 May 2013 13:55:59 GMT

Database name in the create script has a period in it which can affect usablility as periods are used for seperators in naming.

Database has auto_shrink turned on which is only useful for occasionally accessed databases. This database shouldn't get to large so a shrink is not needed.

Database has auto_close turned on which is not nessisary for this database as you will be delayed on opening of the application because the database will need to be brought online before connectivity can be completed.

I am a DBA so these things might be alright for most people, it just bothers me when auto shrink and auto close is used. Sorry.

Thanks for making a great product!
Adam
Comments: ** Comment from web user: adamseniuk **

Sure I can let me revise it. Its actually pretty simple changes the rest of the design is pretty solid just the database has a few features that shouldn't be used.

Commented Unassigned: installing terminals freezes the computer [34067]

dc1673 — Wed, 22 May 2013 15:22:40 GMT

Confirmed on 2008 R2 and Windows 2012 as well during the autodiscovery.

Commented Unassigned: Loading of favorites.xml when notes not in base64 fails [34074]

stecy — Wed, 22 May 2013 12:40:35 GMT

The bug can be reproduced easily with your current favorites.xml file. You just need to edit it with a text editor and change the first record <notes> field to be some normal text instead of base64.

You'll see that favs are not imported anymore since the exception is thrown when trying to convert from base64 (which is not the case here).

Created Unassigned: Version.cs implements part of equality contract [34078]

IDisposable — Tue, 21 May 2013 22:23:22 GMT